lkml.org 
[lkml]   [2014]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/3] perf: clarify comment regarding event merging
Date
There are actually 2 things about software events that allow us to
merge them: they never fail to schedule _and_ they have transaction
handlers we can (and do, when they are added to !sw groups) ignore. Note
both of these in the comment on adding sw events to !sw groups.

Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
---
kernel/events/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index f574401..e9f60d0 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -7065,7 +7065,8 @@ SYSCALL_DEFINE5(perf_event_open,
*
* Allow the addition of software events to !software
* groups, this is safe because software events never
- * fail to schedule.
+ * fail to schedule and have ignorable transaction
+ * handlers ({start,cancel,commit}_txn).
*/
pmu = group_leader->pmu;
} else if (is_software_event(group_leader) &&
--
1.8.5.2


\
 
 \ /
  Last update: 2014-01-10 01:41    [W:0.108 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site