Messages in this thread | | | Date | Thu, 09 Jan 2014 19:07:47 +0000 | From | Sudeep Holla <> | Subject | Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs |
| |
On 08/01/14 20:28, Greg Kroah-Hartman wrote: > On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: >> From: Sudeep Holla <sudeep.holla@arm.com> >> +#define define_one_ro(_name) \ >> +static struct cache_attr _name = \ >> + __ATTR(_name, 0444, show_##_name, NULL) > > In the future, we do have __ATTR_RO(), which should be used instead. > You should never use __ATTR() on it's own, if at all possible. I'm > sweeping the tree for all usages and fixing them slowly up over time. >
Understood, will fix it.
Regards, Sudeep
| |