lkml.org 
[lkml]   [2014]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: simple-card: fix a bug where cinfo will be NULL before using it
On Thu, Jan 09, 2014 at 05:19:08PM +0800, Xiubo Li wrote:

> } else {
> - cinfo->snd_card.dev = &pdev->dev;
> cinfo = pdev->dev.platform_data;
> + cinfo->snd_card.dev = &pdev->dev;
> }

I've applied this since not crashing is good but it's a bug to be
writing to the platform data at all, it should be constant. If it needs
to be written to a copy should be being used.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-01-09 19:01    [W:0.036 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site