Messages in this thread | | | Date | Thu, 9 Jan 2014 15:42:40 +0000 | From | David Vrabel <> | Subject | Re: [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions |
| |
On 09/01/14 15:30, Wei Liu wrote: > On Wed, Jan 08, 2014 at 12:10:10AM +0000, Zoltan Kiss wrote: >> This patch contains the new definitions necessary for grant mapping. >> >> v2: >> - move unmapping to separate thread. The NAPI instance has to be scheduled >> even from thread context, which can cause huge delays >> - that causes unfortunately bigger struct xenvif >> - store grant handle after checking validity >> >> v3: >> - fix comment in xenvif_tx_dealloc_action() >> - call unmap hypercall directly instead of gnttab_unmap_refs(), which does >> unnecessary m2p_override. Also remove pages_to_[un]map members > > Is it worthy to have another function call > gnttab_unmap_refs_no_m2p_override in Xen core driver, or just add a > parameter to control wether we need to touch m2p_override? I *think* it > will benefit block driver as well?
add_m2p_override and remove_m2p_override calls should be moved into the gntdev device as that should be the only user.
David
| |