Messages in this thread | | | Date | Thu, 09 Jan 2014 15:59:38 +0200 | From | Jarkko Nikula <> | Subject | Re: [PATCH] spi: Check conflicting CS based on spi->chip_select instead of device name |
| |
On 01/09/2014 03:23 PM, Mika Westerberg wrote: > Commit e13ac47bec20 (spi: Use stable dev_name for ACPI enumerated SPI > slaves) changed the SPI device naming to be based on ACPI device name > instead of carrying bus number and chip select for devices enumerated > from ACPI namespace. > > In case of a buggy BIOS that lists multiple SPI devices sharing the same > chip select (even though they should use different) the current code fails > to detect that and allows the devices to be added to the bus. > > Fix this by walking through the bus and comparing spi->chip_select instead > of device name. This should work regardless what the device name will be in > future. > > Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > drivers/spi/spi.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 349ebba4b199..13dcc360bde6 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > I guess this is a valid fix in that sense that before my patch those ill-defined SPI devices were not added. Is this something which should go to 3.13?
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
| |