lkml.org 
[lkml]   [2014]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/3] ata: ahci_platform: Manage SATA PHY
On 09-01-2014 14:56, Roger Quadros wrote:

> From: Balaji T K <balajitk@ti.com>

> Some platforms have a PHY hooked up to the
> SATA controller. The PHY needs to be initialized
> and powered up for SATA to work. We do that
> using the PHY framework.

> [Roger Q] Cleaned up.

> CC: Tejun Heo <tj@kernel.org>
> Signed-off-by: Balaji T K <balajitk@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
[...]

> diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
> index d5ced13..b476642 100644
> --- a/drivers/ata/ahci_platform.c
> +++ b/drivers/ata/ahci_platform.c
> @@ -142,6 +142,39 @@ static int ahci_probe(struct platform_device *pdev)
> }
> }
>
> + hpriv->phy = devm_phy_get(dev, "sata-phy");
> + if (IS_ERR(hpriv->phy)) {
> + rc = PTR_ERR(hpriv->phy);
> + switch (rc) {
> + case -ENODEV:
> + case -ENOSYS:
> + /* continue normally */
> + hpriv->phy = NULL;
> + break;
> +
> + case -EPROBE_DEFER:
> + goto disable_unprepare_clk;
> + break;

Well, well, *break* after *goto*? :-)

> +
> + default:
> + dev_err(dev, "couldn't get sata-phy\n");
> + goto disable_unprepare_clk;
> + break;

Again?

WBR, Sergei



\
 
 \ /
  Last update: 2014-01-09 15:01    [W:0.079 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site