Messages in this thread | | | Subject | Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver | From | Rostislav Lisovy <> | Date | Wed, 08 Jan 2014 09:35:33 +0100 |
| |
Hello Dan;
On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote: > On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote: > > This patch adds Comedi driver for Humusoft MF634 (PCIe) and > > MF624 (PCI) data acquisition cards. The legacy card Humusoft > > MF614 is not supported. More info about the cards may be found > > at http://humusoft.cz/produkty/datacq/ > > The driver was tested with both cards. Everything seems to work > > properly. Just the basic functionality of the card (DIO, ADC, DAC) > > is supported by this driver. > > > > Signed-off-by: Rostislav Lisovy <lisovy@gmail.com> > > > > create mode 100644 drivers/staging/comedi/drivers/mf6x4.c > > > > There should be a "---" after the Signed-off-by line and before the > diffstat "create mode 100644 drivers/staging/comedi/drivers/mf6x4.c" > line. Otherwise, the diffstat gets included in the changelog. > > Signed-off-by: Rostislav Lisovy <lisovy@gmail.com> > --- > create mode 100644 drivers/staging/comedi/drivers/mf6x4.c >
You are right, my mistake. But even though there should be v3 patch because I just realized there is an unnecessary comment in mf6x4_detach() and MF6X4_DAC_CHANN_CNT constant is no more used.
Regards; Rostislav Lisovy
| |