lkml.org 
[lkml]   [2014]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 5/5] ARM: exynos5420: add dt node for sss module
    Hello Tomasz,

    On 8 January 2014 06:02, Tomasz Figa <tomasz.figa@gmail.com> wrote:
    > On Tuesday 07 of January 2014 17:21:49 Naveen Krishna Ch wrote:
    >> From: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
    >>
    >> this patch adds the device tree nodes for SSS module found on Exynos5420
    >
    > nit: Sentences in English start with a capital letter. Also this patch
    > adds one node, not few of them as the description suggests.
    >
    > Also patch subject should start with ARM: dts: prefix.
    >
    >>
    >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
    >> TO: <linux-samsung-soc@vger.kernel.org>
    >> CC: Kukjin Kim <kgene.kim@samsung.com>
    >> CC: <linux-crypto@vger.kernel.org>
    >> ---
    >> arch/arm/boot/dts/exynos5420.dtsi | 10 ++++++++++
    >> 1 file changed, 10 insertions(+)
    >>
    >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
    >> index 11dd202..97045f9 100644
    >> --- a/arch/arm/boot/dts/exynos5420.dtsi
    >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
    >> @@ -652,4 +652,14 @@
    >> clocks = <&clock 319>, <&clock 318>;
    >> clock-names = "tmu_apbif", "tmu_triminfo_apbif";
    >> };
    >> +
    >> + sss: sss {
    >
    > Node name should be sss@10830000 as per ePAPR node naming recommendation.
    Thanks for the correction, Will correct it and submit. Thanks
    >
    > Best regards,
    > Tomasz
    >



    --
    Shine bright,
    (: Nav :)


    \
     
     \ /
      Last update: 2014-01-09 05:41    [W:4.123 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site