Messages in this thread Patches in this message | | | Date | Thu, 09 Jan 2014 09:58:42 +0800 | From | ethan zhao <> | Subject | [PATCH Trivial] intel-iommu: check return value of device_to_iommu() before using it |
| |
in function iommu_support_dev_iotlb(),return value of device_to_iommu() is used without checking, this could cause NULL pointer issue.
this patch is for v3.12.6
Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com> --- drivers/iommu/intel-iommu.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index 40203ad..5b4531a 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c @@ -1105,6 +1105,8 @@ static struct device_domain_info *iommu_support_dev_iotlb( struct device_domain_info *info; struct intel_iommu *iommu = device_to_iommu(segment, bus, devfn);
+ if (!iommu) + return NULL; if (!ecap_dev_iotlb_support(iommu->ecap)) return NULL;
-- 1.7.1 From 27d8cdd3fcc6f4ff5cc2ba36d8d5ea0a97823a17 Mon Sep 17 00:00:00 2001 From: ethan.zhao <ethan.zhao@oracle.com> Date: Thu, 9 Jan 2014 08:40:16 -0500 Subject: [PATCH] intel-iommu: check return value of device_to_iommu() before using it
in function iommu_support_dev_iotlb(),return value of device_to_iommu() is used without checking, this could cause NULL pointer issue.
this patch is for v3.12.6
Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com> --- drivers/iommu/intel-iommu.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index 40203ad..5b4531a 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c @@ -1105,6 +1105,8 @@ static struct device_domain_info *iommu_support_dev_iotlb( struct device_domain_info *info; struct intel_iommu *iommu = device_to_iommu(segment, bus, devfn); + if (!iommu) + return NULL; if (!ecap_dev_iotlb_support(iommu->ecap)) return NULL; -- 1.7.1
| |