Messages in this thread | | | From | Qi Wang 王起 (qiwang) <> | Subject | RE: [PATCH 1/1] MTD: UBI: avoid program operation on NOR flash after erasure interrupted | Date | Thu, 9 Jan 2014 01:35:24 +0000 |
| |
Hi Artem: Do you have any suggestion for my modification? Other code I think it is ok. Thanks
-----Original Message----- From: Qi Wang 王起 (qiwang) Sent: Monday, January 06, 2014 1:11 PM To: 'dedekind1@gmail.com' Cc: Adrian Hunter; linux-kernel@vger.kernel.org; linux-mtd@lists.infradead.org Subject: RE: [PATCH 1/1] MTD: UBI: avoid program operation on NOR flash after erasure interrupted
>Please, remember that I pushed your patch to a temporary branch, only >for you to be able to easily pick it. I do not send it upstream.
>As I said, I need to you look at it and confirm that it is all-right. >And if it is not all-right, correct it.
>This is because I modified it myself.
>So waiting for your response on this. I checked the code you modified, compile, and run on our platform, it is ok.
+ ubi_err("cannot invalidate PEB %d, write returned %d write returned %d", + pnum, err, err);
But I think above code print "write err" twice. so I suggest to change to below:
+ ubi_err("cannot invalidate PEB %d, write returned %d", pnum, err); I will send you the patch in another email convenient for you to apply patch. Thanks -- qiwang
| |