Messages in this thread | | | Date | Wed, 08 Jan 2014 15:21:49 -0800 | From | Stephen Boyd <> | Subject | Re: [PATCH v2 1/9] devicetree: bindings: Document Krait/Scorpion cpus and enable-method |
| |
On 01/08/14 06:21, Mark Rutland wrote: > On Tue, Dec 24, 2013 at 12:39:45AM +0000, Stephen Boyd wrote: >> From: Rohit Vaswani <rvaswani@codeaurora.org> >> >> Scorpion and Krait don't use the spin-table enable-method. >> Instead they rely on mmio register accesses to enable power and >> clocks to bring CPUs out of reset. Document their enable-methods. >> >> Cc: <devicetree@vger.kernel.org> >> Signed-off-by: Rohit Vaswani <rvaswani@codeaurora.org> >> [sboyd: Split off into separate patch, renamed methods to >> match compatible nodes] >> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> >> --- >> Documentation/devicetree/bindings/arm/cpus.txt | 25 ++++++++++++++++++++++++- >> 1 file changed, 24 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt >> index 9130435..333f4ae 100644 >> --- a/Documentation/devicetree/bindings/arm/cpus.txt >> +++ b/Documentation/devicetree/bindings/arm/cpus.txt >> @@ -180,7 +180,11 @@ nodes to be present and contain the properties described below. >> be one of: >> "spin-table" >> "psci" >> - # On ARM 32-bit systems this property is optional. >> + # On ARM 32-bit systems this property is optional and >> + can be one of: >> + "qcom,gcc-msm8660" >> + "qcom,kpss-acc-v1" >> + "qcom,kpss-acc-v2" > It would be nice to document "psci" here as valid for 32-bit. > > Currently the PSCI code doesn't inspect the enable-method and assumes it > if there's a psci node, but KVM tool and others set enable-method to > "psci", and if we change the way the PSCI code probes it will require > enable-method to be set for PSCI to work.
Sure. I'll squash it in if I resend, or send a follow-up patch later on.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |