Messages in this thread | | | Date | Wed, 8 Jan 2014 21:09:48 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH v2 3/6] ARM: tegra: Add efuse bindings |
| |
On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: > On 01/08/2014 06:39 AM, Thierry Reding wrote: > > On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: > >> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: > > [...] > >>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > >> > >>> + efuse@7000F800 { > >> > >> "fuse" might be a better node name; "efuse" is presumably the name of > >> the instance, not the type of object. > > > > There's another occurrence I noticed recently where we haven't followed > > that rule. The PMIC node on Venice2 for instance is called as3722. > > Perhaps that should also be renamed. > > Yes, we should fix that. Care to send a patch?
Ugh... I've just been going through some of the other DTS files and see that quite a lot of other places aren't following this rule either. The Beaver DTS has things like:
rt5640: rt5640@1c { ... };
which I guess "should have been"
rt5640: codec@1c { /* or even audio-codec@1c */ ... };
and
pmic: tps65911@2d { ... }; > which would be another candidate for pmic@2d.
Perhaps it isn't worth fixing them all up after all?
Thierry [unhandled content-type:application/pgp-signature] | |