Messages in this thread | | | Date | Wed, 8 Jan 2014 12:30:02 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 2/3] regulator: Add support for S2MPA01 regulator |
| |
On Wed, Jan 08, 2014 at 11:56:29AM +0530, Sachin Kamat wrote:
> + if (!iodev->dev->of_node) { > + if (pdata) { > + goto common_reg; > + } else { > + dev_err(pdev->dev.parent, > + "Platform data or DT node not supplied\n"); > + return -ENODEV; > + } > + }
The driver shouldn't need these to probe, it should be able to start in read only mode with no configuration.
> +static int __init s2mpa01_pmic_init(void) > +{ > + return platform_driver_register(&s2mpa01_pmic_driver); > +} > +subsys_initcall(s2mpa01_pmic_init);
module_platform_driver(). [unhandled content-type:application/pgp-signature] | |