lkml.org 
[lkml]   [2014]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information
On 01/08/2014 04:10 PM, Arnd Bergmann wrote:
> On Wednesday 08 January 2014 15:57:19 Roger Quadros wrote:
>> It is a clock gate defined like so in the DT clock data
>>
>> on OMAP4
>> init_60m_fclk: init_60m_fclk {
>> #clock-cells = <0>;
>> compatible = "ti,divider-clock";
>> clocks = <&dpll_usb_m2_ck>;
>> reg = <0x0104>;
>> ti,dividers = <1>, <8>;
>> };
>>
>> on OMAP5
>> l3init_60m_fclk: l3init_60m_fclk {
>> #clock-cells = <0>;
>> compatible = "ti,divider-clock";
>> clocks = <&dpll_usb_m2_ck>;
>> reg = <0x0104>;
>> ti,dividers = <1>, <8>;
>> };
>>
>> So you can see that it is the same thing with a different name.
>
> Right, but init_60m_fclk is the name of the clock output of the
> divider here, which is /not/ what you should put in the "clock-names"
> property of the consumer. The clock input name should reflect what
> the clock is used for instead.

Ah, now I get it. :). I agree that the name should reflect the function.

Looking more closely, the driver doesn't enable/disable the init_60m_fclk but just
uses it to configure the parent of utmi_p1_gfclk which is a clock input to the
USB module.

Based on this I would call it "refclk_int" for internal reference clock.

cheers,
-roger


\
 
 \ /
  Last update: 2014-01-08 13:21    [W:0.049 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site