Messages in this thread | | | Date | Wed, 8 Jan 2014 11:04:13 +0200 | From | Tomi Valkeinen <> | Subject | Re: [PATCH 0/2] video: mxsfb: fix broken videomode selection |
| |
On 2014-01-06 15:17, Lothar Waßmann wrote: > The first patch in this set converts some messages that are printed > in case of errors to be error messages rather than debug messages. > > The second patch fixes a bug in the video selection code that > incorrectly OR's together the 'pixelclk-active' and 'de-active' > flags from all possible video modes specified in DT into one flag. > > The current code does not allow selecting one specific mode from a > list of video modes, but always uses the last one of the video modes > listed in the DT. > > > Since all current dts files only have one entry in their > 'display-timings' node, this bug was not apparent and the fix does not > change the driver's behaviour for the current users. > > b/drivers/video/mxsfb.c | 6 +-- > drivers/video/mxsfb.c | 120 +++++++++++++++++++++++++++++----------------------------------------- > 2 files changed, 53 insertions(+), 73 deletions(-) >
Thanks, queued for 3.14.
Your diffstat above looks a bit funny. Where did that "b/" come from?
Tomi
[unhandled content-type:application/pgp-signature] | |