Messages in this thread | | | Date | Tue, 7 Jan 2014 17:45:50 -0800 | From | Greg KH <> | Subject | Re: [RFC/PATCH] usb/xhci: avoid kernel panic on xhci_suspend() |
| |
On Tue, Jan 07, 2014 at 05:44:26PM -0800, David Cohen wrote: > From: jianqian <jianqiang.tang@intel.com> > > There is a possible kernel panic faced on xhci_suspend(). > Due to kernel modified the hub autosupend_delay to 0s, after usb1 root > hub finishes initialization, it will trigger runtime_suspend and then > it will trigger xhci runtime suspend. But at that time, if > xhci->shared_hcd is still doing initialization, it is possible to face > null pointer kernel panic in xhci_suspend() function. > > This patch checks if xhci->shared_hcd is null to avoid panic.
That sounds like this is a race that should be fixed properly, not just papered over, right?
thanks,
greg k-h
| |