lkml.org 
[lkml]   [2014]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC/PATCH] usb/xhci: avoid kernel panic on xhci_suspend()
    On Tue, Jan 07, 2014 at 05:44:26PM -0800, David Cohen wrote:
    > From: jianqian <jianqiang.tang@intel.com>
    >
    > There is a possible kernel panic faced on xhci_suspend().
    > Due to kernel modified the hub autosupend_delay to 0s, after usb1 root
    > hub finishes initialization, it will trigger runtime_suspend and then
    > it will trigger xhci runtime suspend. But at that time, if
    > xhci->shared_hcd is still doing initialization, it is possible to face
    > null pointer kernel panic in xhci_suspend() function.
    >
    > This patch checks if xhci->shared_hcd is null to avoid panic.

    That sounds like this is a race that should be fixed properly, not just
    papered over, right?

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2014-01-08 03:21    [W:2.189 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site