Messages in this thread Patch in this message | | | From | Alexander Gordeev <> | Subject | [PATCH 5/7] vfio: Use new interfaces for MSI/MSI-X enablement | Date | Tue, 7 Jan 2014 19:05:40 +0100 |
| |
This update also fixes a bug when deprecated pci_enable_msix() and pci_enable_msi_block() functions return a positive return value which indicats the number of interrupts that could have been allocated rather than a successful allocation. The driver misinterpreted this value and assumed MSI-X/MSIs are enabled, although in fact it were not.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com> --- drivers/vfio/pci/vfio_pci_intrs.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c index 641bc87..66d1746 100644 --- a/drivers/vfio/pci/vfio_pci_intrs.c +++ b/drivers/vfio/pci/vfio_pci_intrs.c @@ -482,15 +482,15 @@ static int vfio_msi_enable(struct vfio_pci_device *vdev, int nvec, bool msix) for (i = 0; i < nvec; i++) vdev->msix[i].entry = i; - ret = pci_enable_msix(pdev, vdev->msix, nvec); - if (ret) { + ret = pci_enable_msix_range(pdev, vdev->msix, nvec, nvec); + if (ret < 0) { kfree(vdev->msix); kfree(vdev->ctx); return ret; } } else { - ret = pci_enable_msi_block(pdev, nvec); - if (ret) { + ret = pci_enable_msi_range(pdev, nvec, nvec); + if (ret < 0) { kfree(vdev->ctx); return ret; } -- 1.7.7.6
| |