lkml.org 
[lkml]   [2014]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3.10 075/129] mm/mempolicy: correct putback method for isolate pages if failed
    On Mon, Jan 06, 2014 at 02:38:24PM -0800, Greg Kroah-Hartman wrote:
    > 3.10-stable review patch. If anyone has any objections, please let me know.

    This commit was tagged for 3.12 stable only, so you may want to drop it.

    Cheers,
    --
    Luis


    > ------------------
    >
    > From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    >
    > commit b0e5fd7359f1ce8db4ccb862b3aa80d2f2cbf4d0 upstream.
    >
    > queue_pages_range() isolates hugetlbfs pages and putback_lru_pages()
    > can't handle these. We should change it to putback_movable_pages().
    >
    > Naoya said that it is worth going into stable, because it can break
    > in-use hugepage list.
    >
    > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    > Acked-by: Rafael Aquini <aquini@redhat.com>
    > Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
    > Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
    > Cc: Christoph Lameter <cl@linux.com>
    > Cc: Vlastimil Babka <vbabka@suse.cz>
    > Cc: Wanpeng Li <liwanp@linux.vnet.ibm.com>
    > Cc: Mel Gorman <mgorman@suse.de>
    > Cc: Rik van Riel <riel@redhat.com>
    > Cc: Vlastimil Babka <vbabka@suse.cz>
    > Cc: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
    > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    >
    > ---
    > mm/mempolicy.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > --- a/mm/mempolicy.c
    > +++ b/mm/mempolicy.c
    > @@ -1271,7 +1271,7 @@ static long do_mbind(unsigned long start
    > if (nr_failed && (flags & MPOL_MF_STRICT))
    > err = -EIO;
    > } else
    > - putback_lru_pages(&pagelist);
    > + putback_movable_pages(&pagelist);
    >
    > up_write(&mm->mmap_sem);
    > mpol_out:
    >
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe stable" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html


    \
     
     \ /
      Last update: 2014-01-07 19:41    [W:4.038 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site