Messages in this thread | | | Date | Tue, 7 Jan 2014 17:05:38 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2] ASoC: soc-core: add snd_soc_of_parse_master_clkdir() for dt |
| |
On Thu, Jan 02, 2014 at 10:48:25AM +0800, Xiubo Li wrote: > This patch adds snd_soc_of_parse_master_clkdir() and supports below > style on dt: > > master-clkdir-out; > > If this property is absent 0 will be returned, 1 otherwise. > 0 : SND_SOC_CLOCK_IN > 1 : SND_SOC_CLOCK_OUT
This is mostly OK code wise, though it would be good to use those constants in the code. However I'm still not sure about it being a good idea - it's similar issues to those with clock IDs but less strong. Do you have a user in mind? [unhandled content-type:application/pgp-signature] | |