lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 4/7] mfd: ssbi: Add regmap read/write helpers
    On 01/06/14 03:50, Lee Jones wrote:
    > On Thu, 26 Dec 2013, Stephen Boyd wrote:
    >
    >> On 12/24, Mark Brown wrote:
    >>> On Mon, Dec 23, 2013 at 12:46:00PM -0800, Stephen Boyd wrote:
    >>>
    >>>> +int ssbi_reg_read(void *context, unsigned int reg, unsigned int *val)
    >>>> +{
    >>>> + *val = 0;
    >>>> + return ssbi_read(context, reg, (u8 *)val, 1);
    >>>> +}
    >>>> +EXPORT_SYMBOL_GPL(ssbi_reg_read);
    >>>> +
    >>>> +int ssbi_reg_write(void *context, unsigned int reg, unsigned int val)
    >>>> +{
    >>>> + return ssbi_write(context, reg, (u8 *)&val, 1);
    >>>> +}
    >>>> +EXPORT_SYMBOL_GPL(ssbi_reg_write);
    >>> Not a big deal but could these just be inlined in the headers?
    >> Sure, I can do that if I need to resend? The only benefit I see
    >> is two less symbols exported.
    > Yes please. After this review.
    >

    Ok done. Just waiting for you to reply on patch 3 until I resend.

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    hosted by The Linux Foundation



    \
     
     \ /
      Last update: 2014-01-06 23:41    [W:2.804 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site