lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [f2fs-dev] [PATCH 2/6] f2fs: convert inline_data for punch_hole
From
Date
Hi,

2013-12-31 (화), 14:08 +0800, Chao Yu:
> Hi,
>
> One comment as following.
>
> > -----Original Message-----
> > From: Jaegeuk Kim [mailto:jaegeuk.kim@samsung.com]
> > Sent: Friday, December 27, 2013 12:00 PM
> > Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
> > Subject: [f2fs-dev] [PATCH 2/6] f2fs: convert inline_data for punch_hole
> >
> > In the punch_hole(), let's convert inline_data all the time for simplicity and
> > to avoid potential deadlock conditions.
> > It is pretty much not a big deal to do this.
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
>
> Reviewed-by: Chao Yu <chao2.yu@samsung.com>
>
> > ---
> > fs/f2fs/file.c | 22 +++-------------------
> > 1 file changed, 3 insertions(+), 19 deletions(-)
> >
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index 7ef2d6a..f64a1c8 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -462,25 +462,9 @@ static int punch_hole(struct inode *inode, loff_t offset, loff_t len)
> > loff_t off_start, off_end;
> > int ret = 0;
> >
> > - if (f2fs_has_inline_data(inode)) {
> > - struct page *page;
> > - unsigned flags = AOP_FLAG_NOFS;
> > - page = grab_cache_page_write_begin(inode->i_mapping, 0, flags);
> > - if (IS_ERR(page))
> > - return PTR_ERR(page);
>
> We use following code because grab_cache_page_write_begin only use
> NULL value as its error number.

Right. :)
Applied to the following patch:
f2fs: refactor f2fs_convert_inline_data.

Thanks,

--
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-01-06 09:21    [W:0.072 / U:1.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site