Messages in this thread | | | Date | Tue, 7 Jan 2014 01:44:38 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] netfilter: nf_conntrack: release conntrack from rcu callback |
| |
On Mon, Jan 06, 2014 at 10:23:26PM +0100, Florian Westphal wrote: > > > > No? Or there something obvious I'm missing? > > IMHO this isn't obvious at all :-) > > But, in the example above, the atomic_inc_not_zero() should fail > until after __nf_conntrack_alloc() re-inits the refcount to 1. > > The mb there should make sure ____nf_conntrack_find() doesn't > find an outdated tuple before this.
Yeah, thanks!
| |