lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC RESEND PATCH 1/1] thermal: introduce clock cooling device
Hi!

> --- /dev/null
> +++ b/drivers/thermal/clock_cooling.c
> @@ -0,0 +1,484 @@
> +/*
> + * drivers/thermal/cpu_cooling.c

Bit too much copy&paste...


> + * Copyright (C) 2013 Texas Instruments Inc.
> + * Contact: Eduardo Valentin <eduardo.valentin@ti.com>
> + *
> + * Highly based on cpu_cooling.c.

Check english. And you should add samsung & linaro copyright here,
since you copied from it.

> + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

can we get rid of ~~~s?

> +static int clock_cooling_get_property(struct clock_cooling_device *ccdev,
> + unsigned long input,
> + unsigned long *output,
> + enum clock_cooling_property property)
> +{
> + int i, j;
> + unsigned long max_level = 0, level = 0;
...
> + if (property == GET_MAXL) {
> + *output = (unsigned int)max_level;

What is going on with types here? Remove cast?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2014-01-06 22:41    [W:0.035 / U:1.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site