Messages in this thread | | | Subject | Re: [PATCH 13/21] mac8011: slight optimization of addr compare | From | Johannes Berg <> | Date | Mon, 06 Jan 2014 16:21:17 +0100 |
| |
On Mon, 2013-12-23 at 13:10 +0800, Ding Tianhong wrote: > Use the recently added and possibly more efficient > ether_addr_equal_unaligned to instead of memcmp.
> - if (memcmp(local->hw.wiphy->addresses[i].addr, > - sdata->vif.addr, ETH_ALEN) == 0) { > + if (ether_addr_equal_unaligned(local->hw.wiphy->addresses[i].addr, sdata->vif.addr)) {
This clearly should have some linebreaks.
This code also doesn't care all that much about efficiency, so not sure it's worth it at all.
johannes
| |