lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq
On Mon, 6 Jan 2014 15:38:28 +0100
Jiri Olsa <jolsa@redhat.com> wrote:


> > I just thought that it's not so important to print message so keeps the
> > error internally until it gets printed. But I can be wrong as usual...
>
> I think that if she manages to get one of those errors
> the perf would fail soon anyway.. so it feels better
> to print it out immediately.

Yeah, using a trace_seq after it has been destroyed is a critical
failure, and a major bug. A print to the user console should not be a
problem here. And actually, crashing is not that bad either, as glibc
does the same with using free() of a freed pointer.

But as this error is major, an unwanted print is minor.

-- Steve


\
 
 \ /
  Last update: 2014-01-06 17:01    [W:0.053 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site