Messages in this thread | | | Subject | Re: [PATCH 4/11] use ether_addr_equal_64bits | From | Johannes Berg <> | Date | Mon, 06 Jan 2014 10:05:47 +0100 |
| |
On Tue, 2013-12-31 at 17:40 +0100, Julia Lawall wrote:
> > If nothing else, then some run-time code that calculates the offset off > > and asserts if it is broken in module initialization or similar might > > be good enough. > > Could be OK. Something right in or after the structure declaration would > be nicest.
I don't think you can put a BUILD_BUG_ON() into the structure declaration (it's code, not declarations), but I think you could just put
BUILD_BUG_ON(sizeof(struct foo) - offsetof(struct foo, addr) < 8);
with the user(s?) and that should catch the scenario I was worrying about?
johannes
| |