lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/4] futex: silence uninitialized warnings
From
Date
On Tue, 2014-01-07 at 10:55 +0800, Linus Torvalds wrote:
> On Mon, Jan 6, 2014 at 9:38 AM, Davidlohr Bueso <davidlohr@hp.com> wrote:
> > {
> > int lock_taken, ret, force_take = 0;
> > - u32 uval, newval, curval, vpid = task_pid_vnr(task);
> > + u32 uval, newval, uninitialized_var(curval), vpid = task_pid_vnr(task);
>
> Do you have some broken compiler?

I only notice this when testing this patchset on our servers with RHEL
6.4 (gcc 4.4.7 20120313 (Red Hat 4.4.7-3)).

> I really tend to hate this kind of
> workarounds, because as mentioned, they can actually hide valid
> warnings, and it seems to be due to just stupid compilers. Are we
> perhaps better off trying to get people off the broken compiler
> versions instead?

As Darren points out, this path is unlikely to change, but I have no
particular preference otherwise.



\
 
 \ /
  Last update: 2014-01-07 04:41    [W:0.074 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site