lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 026/129] arm64: spinlock: retry trylock operation if strex fails on free lock
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Catalin Marinas <catalin.marinas@arm.com>

    commit 4ecf7ccb1973fd826456b6ab1e6dfafe9023c753 upstream.

    An exclusive store instruction may fail for reasons other than lock
    contention (e.g. a cache eviction during the critical section) so, in
    line with other architectures using similar exclusive instructions
    (alpha, mips, powerpc), retry the trylock operation if the lock appears
    to be free but the strex reported failure.

    Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
    Reported-by: Tony Thompson <anthony.thompson@arm.com>
    Acked-by: Will Deacon <will.deacon@arm.com>
    Cc: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm64/include/asm/spinlock.h | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/arch/arm64/include/asm/spinlock.h
    +++ b/arch/arm64/include/asm/spinlock.h
    @@ -59,9 +59,10 @@ static inline int arch_spin_trylock(arch
    unsigned int tmp;

    asm volatile(
    - " ldaxr %w0, %1\n"
    + "2: ldaxr %w0, %1\n"
    " cbnz %w0, 1f\n"
    " stxr %w0, %w2, %1\n"
    + " cbnz %w0, 2b\n"
    "1:\n"
    : "=&r" (tmp), "+Q" (lock->lock)
    : "r" (1)



    \
     
     \ /
      Last update: 2014-01-07 04:41    [W:2.783 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site