Messages in this thread | | | Subject | Re: [PATCH] lib/vsprintf: add %pT[C012] format specifier | From | Joe Perches <> | Date | Sun, 05 Jan 2014 10:09:52 -0800 |
| |
On Sun, 2014-01-05 at 12:15 +0900, Tetsuo Handa wrote: > Tetsuo Handa wrote: > > Since my purpose is to make reading of task_struct->comm consistent, %pT-like > > extension is what I want for centralizing pointer dereferences. > > If we have no objections for %pT[C012] patch,
I still believe emitting different output styles using %pT[012] is not ideal.
Is this really necessary?
I'd prefer that each element be described separately using %pT<type> where T is a struct task_struct and type is a member.
type 'c' -> tsk.comm type 'p' -> tsk.pid type 't' -> task.tgid
though if the real concern is simply comm consistency, maybe these other member types aren't at all useful.
| |