lkml.org 
[lkml]   [2014]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next] r8152: fix the wrong return value
Date

David Miller [mailto:davem@davemloft.net]
> Sent: Saturday, January 04, 2014 9:38 AM
> To: Hayeswang
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next] r8152: fix the wrong return value
>
> From: Hayes Wang <hayeswang@realtek.com>
> Date: Fri, 3 Jan 2014 11:21:56 +0800
>
> > The return value should be the boolean value, not the error code.
> >
> > Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> > Spotted-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied, but I agree with others that it's more canonical to have the
> function return either an error code, or zero for success, rather than
> a boolean.

Thanks. I would find if there is suitable error code.

Best Regards,
Hayes



\
 
 \ /
  Last update: 2014-01-06 04:41    [W:0.379 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site