Messages in this thread | | | Date | Fri, 31 Jan 2014 10:45:51 -0800 | Subject | Re: x86, x32: Correct invalid use of user timespec in the kernel | From | Linus Torvalds <> |
| |
On Fri, Jan 31, 2014 at 10:06 AM, H. Peter Anvin <hpa@linux.intel.com> wrote: > > My feeling is that {get,put}_compat_timespec() should at the very least > have leading underscores to flag it as a low-level function, but better > suggestions would be appreciated.
Why not just remove it entirely, and change all users to compat_[get|set]_timespec (same for timeval etc, of course).
After all, compat_*_time*() does fall back cleanly for non-x32 cases. And sure, maybe that particular code is never *needed* for x32 support, but the overhead is generally zero (since in most cases X32 isn't even configured), or very low anyway. So the upside of having two subtly incompatible interfaces is very dubious, no?
Linus
| |