Messages in this thread | | | Date | Fri, 31 Jan 2014 03:18:50 +0100 | From | Sebastian Hesselbarth <> | Subject | Re: [PATCH v2 00/21] pinctrl: mvebu: restructure and remove hardcoded addresses from Dove pinctrl |
| |
On 01/30/2014 09:25 PM, Andrew Lunn wrote: > On Thu, Jan 30, 2014 at 07:50:34PM +0100, Sebastian Hesselbarth wrote: >> On 01/30/2014 07:29 PM, Andrew Lunn wrote: >>> On Tue, Jan 28, 2014 at 01:39:12AM +0100, Sebastian Hesselbarth wrote: >>>> This patch set is one required step for Dove to hop into mach-mvebu. >>>> Until now, pinctrl-dove was hardcoding some registers that do not >>>> directly belong to MPP core registers. This is not compatible with >>>> what we want for mach-mvebu. >>> >>> I think there might be something wrong here.... >> >> There _is_ something wrong. I'll have a look at it. For the record, >> what SoC are you testing with? From the base address, I guess it is >> Kirkwood? > > Yes, Kirkwood. Sorry for not saying.
This time I push a branch before sending out the patches. Also, I think I'll postpone removal of hardcoded addresses until this is sorted out. The patch set was growing way to quick and I have to do this step-by-step for me and everybody else to actually understand ;)
So, at least the MVEBU guys should test the following branch on their SoCs. Again, I have tested Dove and now confirmed that settings are still correct. The others are compile-tested.
https://github.com/shesselba/linux-dove.git unstable/mvebu-pinctrl-v3.14_v3
@Thomas, Gregory: Do you think that the above branch will be restructured enough allow support for orion5x and mv78xx0? I had a quick look at mach-{orion5x,mv78xx0}/mpp.h and didn't see anything weird.
Sebastian
| |