Messages in this thread | | | From | Tom Gundersen <> | Date | Fri, 31 Jan 2014 01:54:03 +0100 | Subject | Re: [PATCH] net: set default DEVTYPE for all ethernet based devices |
| |
Hi Veaceslav,
Thanks for your quick reply.
On Thu, Jan 30, 2014 at 4:05 PM, Veaceslav Falico <vfalico@redhat.com> wrote: > On Thu, Jan 30, 2014 at 02:20:02PM +0100, Tom Gundersen wrote: >> >> In systemd's networkd and udevd, we would like to give the administrator a >> simple way to filter net devices by their DEVTYPE [0][1]. Other software >> such as ConnMan and NetworkManager uses a similar filtering already. >> >> Currently, plain ethernet devices have DEVTYPE=(null). This patch sets the >> devtype to "ethernet" instead. This avoids the need for special-casing the >> DEVTYPE=(null) case in userspace, and also avoids false positives, as >> there >> are several other types of netdevs that also have DEVTYPE=(null). > > > There are quite a few users at least in usb and wireless drivers: > > net#git grep alloc_etherdev drivers/net/wireless/ drivers/net/usb | wc -l > 18 > > In usb, though, there might be some false positives of this grep, as > there are a few devices which might be considered ethernet.
Ah, yes I missed the #define of alloc_etherdev(). Looking through these, it shouldn't be too hard to keep this patch and additionally fix up the false positives to opt-out of setting the DEVTYPE. Does that sound like something that would be acceptable?
Cheers,
Tom
| |