Messages in this thread | | | Date | Thu, 30 Jan 2014 14:54:08 -0800 | From | Randy Dunlap <> | Subject | Re: [BUG] Description for memmap in kernel-parameters.txt is wrong |
| |
On 01/30/2014 02:17 PM, David Rientjes wrote: > On Thu, 30 Jan 2014, Randy Dunlap wrote: > >>>>> Hi, >>>>> >>>>> In kernel-parameters.txt, there is following description: >>>>> >>>>> memmap=nn[KMG]$ss[KMG] >>>>> [KNL,ACPI] Mark specific memory as reserved. >>>>> Region of memory to be used, from ss to ss+nn. >>>> >>>> Should be: >>>> Region of memory to be reserved, from ss to ss+nn. >>>> >>>> but that doesn't help with the problem that you describe, does it? >>>> >>> >>> Actually it should be: >>> Region of memory to be reserved, from nn to nn+ss. >>> >>> That is, exchange nn and ss. >> >> Yes, I understand that that's what you are reporting. I just haven't yet >> worked out how the code manages to exchange those 2 values. >> > > It doesn't, the documentation is correct as written and could be improved > by your suggestion of "Region of memory to be reserved, from ss to ss+nn." > I think Andiry probably is having a problem with his bootloader > interpreting the '$' incorrectly (or variable expansion if coming from the > shell) or interpreting the resulting user-defined e820 map incorrectly. > --
Yeah, I certainly don't see a problem with the code and I would want to see/understand that before I exchanged the 2 values in the documentation.
I'll submit a patch to make the wording a bit better.
Thanks.
-- ~Randy
| |