Messages in this thread | | | Date | Thu, 30 Jan 2014 20:50:00 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] pinctrl: Avoid kasprintf/kfree |
| |
On Thu, Jan 30, 2014 at 12:37:36PM -0800, Joe Perches wrote:
> + char propname[9 + sizeof(int) * 2 + 4] = "pinctrl-";
I'm not sure this is a triumph of legibility - there's several magic numbers there and it's not blindlingly obvious where the caclculation came from. Is this really a hot enough code path to benefit from an optimisation like this? [unhandled content-type:application/pgp-signature] | |