lkml.org 
[lkml]   [2014]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pinctrl: Avoid kasprintf/kfree
On Thu, Jan 30, 2014 at 12:37:36PM -0800, Joe Perches wrote:

> + char propname[9 + sizeof(int) * 2 + 4] = "pinctrl-";

I'm not sure this is a triumph of legibility - there's several magic
numbers there and it's not blindlingly obvious where the caclculation
came from. Is this really a hot enough code path to benefit from an
optimisation like this?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-01-30 22:21    [W:0.079 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site