Messages in this thread | | | Date | Thu, 30 Jan 2014 14:39:49 -0500 (EST) | From | Nicolas Pitre <> | Subject | Re: [RFC PATCH 1/3] cpuidle: split cpuidle_idle_call main function into functions |
| |
On Thu, 30 Jan 2014, Daniel Lezcano wrote:
> /** > + * cpuidle_select - ask the cpuidle framework to choose an idle state > + * > + * @drv: the cpuidle driver > + * @dev: the cpuidle device > + * > + * Returns the index of the idle state. On error it returns: > + * -NODEV : the cpuidle framework is available
s/available/not available/
> + * -EBUSY : the cpuidle framework is not initialized > + */ > +int cpuidle_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) > +{ > + if (off || !initialized) > + return -ENODEV; > + > + if (!drv || !dev || !dev->enabled) > + return -EBUSY; > + > + return cpuidle_curr_governor->select(drv, dev); > +} > +EXPORT_SYMBOL(cpuidle_select);
Peterz comment notwithstanding, is there actually a need to export those symbols? No modules should ever need to use this given this is going to be called by the scheduler code.
Ditto for the other symbols.
Nicolas
| |