lkml.org 
[lkml]   [2014]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v12 08/18] xen/pvh: Load GDT/GS in early PV bootup code for BSP.
On 02/01/14 18:24, Konrad Rzeszutek Wilk wrote:
>>> + loadsegment(es, 0);
>>> + loadsegment(ds, 0);
>>> + loadsegment(fs, 0);
>>> +#else
>>> + /* PVH: TODO Implement. */
>>> + BUG();
>>> +#endif
>>> + return; <==============
>>> + }
>>> pv_cpu_ops.write_gdt_entry = xen_write_gdt_entry_boot;
>>> pv_cpu_ops.load_gdt = xen_load_gdt_boot;
>>
>> If PVH uses native GDT why are these (and possibly other?) GDT ops needed?
>
> They aren't. There is a 'return' there. I marked it for you with
> '<======'.

I missed that, in which case.

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

David


\
 
 \ /
  Last update: 2014-01-03 13:01    [W:0.098 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site