Messages in this thread | | | Date | Thu, 2 Jan 2014 23:45:11 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support |
| |
Hi Xiubo,
On Fri, Jan 03, 2014 at 01:24:21PM +0800, Xiubo Li wrote: > + > +static inline int fsl_pwm_calculate_default_ps(struct fsl_pwm_chip *fpc, > + enum fsl_pwm_clk index) > +{
Why do you declare this (and other module-local) function as inline? It is usually better let compiler decide if given function should be inlined or not.
[...]
> + > +static int fsl_pwm_remove(struct platform_device *pdev) > +{ > + struct fsl_pwm_chip *fpc = platform_get_drvdata(pdev); > + > + mutex_destroy(&fpc->lock); > + > + return pwmchip_remove(&fpc->chip);
fpc->lock will be used while pwmchip_remove() is running so you should not be destroying it before calling pwmchip_remove(). It should probbaly go into free() method or just drop it altogether.
Thanks.
-- Dmitry
| |