Messages in this thread | | | Date | Sat, 04 Jan 2014 11:31:47 +0800 | From | Bob Liu <> | Subject | Re: [PATCH] mm/mlock: fix BUG_ON unlocked page for nolinear VMAs |
| |
On 01/04/2014 04:52 AM, Linus Torvalds wrote: > On Fri, Jan 3, 2014 at 12:17 PM, Sasha Levin <sasha.levin@oracle.com> wrote: >> >> Ping? This BUG() is triggerable in 3.13-rc6 right now. > > So Andrew suggested just removing the BUG_ON(), but it's been there > for a *long* time. > > And I detest the patch that was sent out that said "Should I check?" > > Maybe we should just remove that mlock_vma_page() thing instead in > try_to_unmap_cluster()? Or maybe actually lock the page around calling
I didn't get the reason why we have to call mlock_vma_page() in try_to_unmap_cluster() and I agree to just remove it.
> it? > > Linus >
-- Regards, -Bob
| |