Messages in this thread | | | From | Bjorn Helgaas <> | Date | Fri, 3 Jan 2014 17:00:42 -0700 | Subject | Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines |
| |
On Fri, Jan 3, 2014 at 4:56 PM, David Miller <davem@davemloft.net> wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > Date: Fri, 3 Jan 2014 15:15:57 -0700 > >> However, I do raise my eyebrows a bit at drivers that poke around in >> the PCIe capability. I would prefer to have PCI core interfaces that >> handle that instead. But I haven't seen Jeff's changes yet. > > The changes just read the link status to interpret the speed at which > the PCI-E link is running at.
Several drivers want to do that. It'd be nice if somebody abstracted that out somehow. Jacob added pcie_get_minimum_link() which is similar. But maybe Jeff needs something more in this case.
In any case, it's not a blocker for this patch.
Bjorn
| |