lkml.org 
[lkml]   [2014]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 49/73] drivers/mtd: delete non-required instances of include <linux/init.h>
On 14-01-28 07:02 PM, Brian Norris wrote:
> On Tue, Jan 21, 2014 at 04:22:52PM -0500, Paul Gortmaker wrote:
>> None of these files are actually using any __init type directives
>> and hence don't need to include <linux/init.h>. Most are just a
>> left over from __devinit and __cpuinit removal, or simply due to
>> code getting copied from one driver to the next.
>>
>> Cc: David Woodhouse <dwmw2@infradead.org>
>> Cc: Brian Norris <computersforpeace@gmail.com>
>> Cc: linux-mtd@lists.infradead.org
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
>> diff --git a/drivers/mtd/maps/sa1100-flash.c b/drivers/mtd/maps/sa1100-flash.c
>> index 8fc06bf..3428034e 100644
>> --- a/drivers/mtd/maps/sa1100-flash.c
>> +++ b/drivers/mtd/maps/sa1100-flash.c
>> @@ -7,7 +7,6 @@
>> #include <linux/types.h>
>> #include <linux/ioport.h>
>> #include <linux/kernel.h>
>> -#include <linux/init.h>
>> #include <linux/errno.h>
>> #include <linux/slab.h>
>> #include <linux/platform_device.h>
>
> This file uses __exit_p(), from <linux/init.h>. So I dropped this hunk
> and pushed the rest to l2-mtd.git/next.

Thanks! Not sure why that got caught up in the review, since I had __exit
in my regex filter. It had module.h so I never caught the false positive in
my build testing either.

Paul.
--
>
> Thanks,
> Brian
>


\
 
 \ /
  Last update: 2014-01-29 16:41    [W:0.111 / U:1.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site