Messages in this thread | | | Date | Tue, 28 Jan 2014 21:02:36 -0800 (PST) | From | David Rientjes <> | Subject | Re: [RFC][PATCH] mm: sl[uo]b: fix misleading comments |
| |
On Tue, 28 Jan 2014, Dave Hansen wrote:
> From: Dave Hansen <dave.hansen@linux.intel.com> > > On x86, SLUB creates and handles <=8192-byte allocations internally. > It passes larger ones up to the allocator. Saying "up to order 2" is, > at best, ambiguous. Is that order-1? Or (order-2 bytes)? Make > it more clear. > > SLOB commits a similar sin. It *handles* page-size requests, but the > comment says that it passes up "all page size and larger requests". > > SLOB also swaps around the order of the very-similarly-named > KMALLOC_SHIFT_HIGH and KMALLOC_SHIFT_MAX #defines. Make it > consistent with the order of the other two allocators. > > Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: David Rientjes <rientjes@google.com>
| |