Messages in this thread | | | Date | Wed, 29 Jan 2014 07:36:08 +0800 | From | Tang Chen <> | Subject | Re: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug(). |
| |
On 01/28/2014 07:48 PM, Ingo Molnar wrote: > > * David Rientjes<rientjes@google.com> wrote: > >> On Tue, 28 Jan 2014, Tang Chen wrote: >> >>> On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug() >>> was not initialized. So we need to initialize it. >>> >>> Signed-off-by: Tang Chen<tangchen@cn.fujitsu.com> >>> Tested-by: Gu Zheng<guz.fnst@cn.fujitsu.com> >> >> Reported-by: David Rientjes<rientjes@google.com> > > Agreed. Tang Chen, please also spell it out in the changelog: > > David Rientjes reported a boot crash, caused by > commit XYZ ("foo: bar"). > > I find it somewhat annoying that you found time to credit a corporate > collegue with a Tested-by tag, who didn't even reply to the whole > thread to indicate his testing efforts, but you didn't find the time > to credit the original reporter of the bug who also reviewed your > patches ...
Hi David, Ingo,
I'm sorry for the missing original reporter. I was paying so much attention to the second patch. And Andrew has added the missing info and committed the patch. :)
Thanks.
> > Thanks, > > Ingo >
| |