Messages in this thread | | | Date | Tue, 28 Jan 2014 20:14:59 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 5/9] sched: Push put_prev_task() into pick_next_task() |
| |
On Tue, Jan 28, 2014 at 10:46:18AM -0800, bsegall@google.com wrote: > > @@ -4734,7 +4729,7 @@ static void migrate_tasks(unsigned int d > > if (rq->nr_running == 1) > > break; > > > > - next = pick_next_task(rq); > > + next = pick_next_task(rq, NULL); > > This seems to be incorrect without the if (prev) lines in > pick_next_task_foo, since foo_nr_running isn't enough to save us.
ARgh, I knew there must've been a reason I had those :/
| |