Messages in this thread Patches in this message | | | Date | Tue, 28 Jan 2014 09:12:27 -0800 | Subject | Re: [PATCH 1/3] memblock, nobootmem: Add memblock_virt_alloc_low() | From | Yinghai Lu <> |
| |
On Tue, Jan 28, 2014 at 7:30 AM, Kevin Hilman <khilman@linaro.org> wrote: > On Tue, Jan 28, 2014 at 12:02 AM, Olof Johansson <olof@lixom.net> wrote: >> Hi, >> >> On Fri, Jan 24, 2014 at 11:11 AM, Yinghai Lu <yinghai@kernel.org> wrote: >>> The new memblock_virt APIs are used to replaced old bootmem API. >>> >>> We need to allocate page below 4G for swiotlb. >>> >>> That should fix regression on Andrew's system that is using swiotlb. >>> >>> Signed-off-by: Yinghai Lu <yinghai@kernel.org> >>> Cc: Russell King <linux@arm.linux.org.uk> >>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >> >> This seems to have been merged by Linus tonight as ad6492b80f, and it >> had fallout on ARM systems (boot failures with no console output on >> all but 5 of my machine/config combos). >> >> Seems like it didn't have a chance to sit in -next, which is somewhat >> understandable given that it's considered a bugfix and it indeed fixed >> the bug it was meant to. >> >> i'm out of time to debug this tonight (I noticed the failures as I was >> heading to bed and figured I'd at least bisect them), so I wouldn't >> mind seeing a revert of the ARM side change of ad6492b80f until it's >> been sorted out so we keep bisectabilty intact for the rest of the >> kernel. > > Like Olof, I noticed multiple boot failures on various ARM boards. > I've confirmed that reverting the arch/arm part of this patch makes > them all happily booting again.
please try attached patch.
Index: linux-2.6/include/linux/bootmem.h =================================================================== --- linux-2.6.orig/include/linux/bootmem.h +++ linux-2.6/include/linux/bootmem.h @@ -179,6 +179,9 @@ static inline void * __init memblock_vir NUMA_NO_NODE); }
+/* Take arch's ARCH_LOW_ADDRESS_LIMIT at first*/ +#include <asm/processor.h> + #ifndef ARCH_LOW_ADDRESS_LIMIT #define ARCH_LOW_ADDRESS_LIMIT 0xffffffffUL #endif--- include/linux/bootmem.h | 3 +++ 1 file changed, 3 insertions(+)
Index: linux-2.6/include/linux/bootmem.h =================================================================== --- linux-2.6.orig/include/linux/bootmem.h +++ linux-2.6/include/linux/bootmem.h @@ -179,6 +179,9 @@ static inline void * __init memblock_vir NUMA_NO_NODE); } +/* Take arch's ARCH_LOW_ADDRESS_LIMIT at first*/ +#include <asm/processor.h> + #ifndef ARCH_LOW_ADDRESS_LIMIT #define ARCH_LOW_ADDRESS_LIMIT 0xffffffffUL #endif | |