lkml.org 
[lkml]   [2014]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] numa, mem-hotplug: Initialize numa_kernel_nodes in numa_clear_kernel_node_hotplug().

* David Rientjes <rientjes@google.com> wrote:

> On Tue, 28 Jan 2014, Tang Chen wrote:
>
> > On-stack variable numa_kernel_nodes in numa_clear_kernel_node_hotplug()
> > was not initialized. So we need to initialize it.
> >
> > Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> > Tested-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>
> Reported-by: David Rientjes <rientjes@google.com>

Agreed. Tang Chen, please also spell it out in the changelog:

David Rientjes reported a boot crash, caused by
commit XYZ ("foo: bar").

I find it somewhat annoying that you found time to credit a corporate
collegue with a Tested-by tag, who didn't even reply to the whole
thread to indicate his testing efforts, but you didn't find the time
to credit the original reporter of the bug who also reviewed your
patches ...

Thanks,

Ingo


\
 
 \ /
  Last update: 2014-01-28 13:21    [W:0.101 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site