Messages in this thread | | | Subject | Re: [RFC] x86: Disable traditional FPU instructions too | From | "H. Peter Anvin" <> | Date | Tue, 28 Jan 2014 02:25:09 -0800 |
| |
If that is intentional it needs a big huge freaking comment recording why it is not a bug. I would expect that to generate a FP multiply.
On January 28, 2014 1:37:01 AM PST, Michal Hocko <mhocko@suse.cz> wrote: >[CCing Ralf for MIPS.] > >On Mon 27-01-14 17:45:44, Borislav Petkov wrote: >> On Mon, Jan 27, 2014 at 08:41:09AM -0800, H. Peter Anvin wrote: >> > I don't think it'd hurt... although I think the above pretty much >> > requires that the code contain actual floating-point types to ever >be >> > generated. >> >> Yes, that is supposed to catch usage of the 'E' floating constant, >for >> example, in definitions. It is a build-time assertion, if you want. >:) > >And git grep says that mips abuses this notation: >arch/mips/include/asm/kvm_host.h:#define MS_TO_NS(x) (x * 1E6L) > >I do not have cross-compiler set up to check whether this is a real >issue because include/media/rc-core.h defines the same macro correctly >so the real code might end up using the right variant.
-- Sent from my mobile phone. Please pardon brevity and lack of formatting.
| |