Messages in this thread | | | From | "Dorau, Lukasz" <> | Subject | RE: [PATCH] for_each macros correctness | Date | Mon, 27 Jan 2014 09:26:45 +0000 |
| |
On Sunday, January 26, 2014 11:54 AM Jose Alonso <joalonsof@gmail.com> wrote: > I observed that there are for_each macros that do an extra memory access > beyond the defined area. > Normally this does not cause problems. > But, this can cause exceptions. For example: if the area is allocated at > the end of a page and the next page is not accessible. > > For correctness, I suggest changing the arguments of the 'for loop' like > others 'for_each' do in the kernel. > > files involved: > drivers/s390/cio/qdio.h > drivers/scsi/isci/host.h
Hi Jose,
The macro in "drivers/scsi/isci/host.h" has already been corrected: http://marc.info/?l=linux-kernel&m=139030404415970&w=2 So you can remove the part regarding "drivers/scsi/isci/host.h" from your patch.
Lukasz
| |