lkml.org 
[lkml]   [2014]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] perf tools: Fix traceevent plugin path definitions
Date
On Wed, 22 Jan 2014 10:01:48 -0500, Josh Boyer wrote:
> The plugindir_SQ definition contains $(prefix) which is not needed
> as the $(libdir) definition already contains prefix in it. This
> leads to the path including an extra prefix in it, e.g. /usr/usr/lib64.
>
> The -DPLUGIN_DIR defintion includes DESTDIR. This is incorrect, as it
> sets the plugin search path to include the value of DESTDIR. DESTDIR
> is a mechanism to install in a non-standard location such as a chroot
> or an RPM build root. In the RPM case, this leads to the search path
> being incorrect after the resulting RPM is installed (or in some cases
> an RPM build failure).
>
> Remove both of these unnecessary inclusions.

Oops, I replied before reading this and previous discussion.. :-/

Anyway it looks good to me too.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2014-01-27 07:01    [W:0.056 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site