lkml.org 
[lkml]   [2014]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/21] perf tools: Introduce struct hist_entry_iter
    On Mon, Jan 27, 2014 at 02:41:43PM +0900, Namhyung Kim wrote:
    > On Thu, 23 Jan 2014 15:44:00 +0100, Jiri Olsa wrote:
    > > On Thu, Jan 23, 2014 at 09:13:45AM +0900, Namhyung Kim wrote:
    > >> There're some duplicate code when adding hist entries. They are
    > >> different in that some have branch info or mem info but generally do
    > >> same thing. So introduce new struct hist_entry_iter and add callbacks
    > >> to customize each case in general way.
    > >>
    > >> The new perf_evsel__add_entry() function will look like:
    > >>
    > >> iter->prepare_entry();
    > >> iter->add_single_entry();
    > >>
    > >> while (iter->next_entry())
    > >> iter->add_next_entry();
    > >>
    > >> iter->finish_entry();
    > >>
    > >> This will help further work like the cumulative callchain patchset.
    >
    > [SNIP]
    > >> - if (rep->hide_unresolved && !al->sym)
    > >> - return 0;
    > >
    > > this check seems to be missing in iter_add_single_mem_entry
    >
    > Right. But afaics it's duplicate as we already check it in
    > process_sample_event().

    ok.. missed that

    jirka


    \
     
     \ /
      Last update: 2014-01-27 10:21    [W:4.583 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site